search

sugarlabs / countries-activity

GNU General Public License v3.0
1 stars 9 forks source link

Port to Python3 #15

Closed chimosky closed 4 years ago

chimosky commented 4 years ago

@quozl kindly review.

Aniket21mathur commented 4 years ago

Thanks. Reviewed. Though it was a bit difficult to compare the changes for utils.py file. Github shows every line changed for that file, but clearly it's not the case. I don't find many actual changes in the utils.py file. Use of 2to3 for porting results in this sometimes.

quozl commented 4 years ago

Was caused by the files haveing CRLF line terminators, which is DOS format.

I've converted them and pushed 9eb60d389a4f08b7f634771f6b1f0db6a0983bea.

Please rebase.

chimosky commented 4 years ago

@quozl kindly review.

quozl commented 4 years ago

Thanks. Reviewed. Merged by hand to fix the commit messages; extraneous period at end of line, and didn't follow established style.