search

sugarlabs / countries-activity

GNU General Public License v3.0
1 stars 9 forks source link

Updated Name of Countries and removed duplicate with original official names. #24

Closed drLite35 closed 6 months ago

drLite35 commented 7 months ago

Updates Name of countries to new official names. This PR closes https://github.com/sugarlabs/countries-activity/issues/22 Sources :- Official Names of the United Nations Membership https://www.un.int https://worldpopulationreview.com

SohamKukreti commented 7 months ago

Thank you for the pull request. There are a few issues with your pull request:

  1. Please comply with imperative tense recommendation and others in how to make commits.
  2. Along with the names, the order of flags need to be updated too.
  3. The latlon.txt file would need to be updated too.
  4. Try to maintain the lexicographical order of countries (North Macedonia needs to placed correctly).
drLite35 commented 7 months ago

Kindly review @walterbender @chimosky @quozl. Maintained order across all files. Also I am unsure if name of png files hold any significance I have named them so that they can be in order.

SohamKukreti commented 7 months ago

Thank you for updating the flags, however there might be some mistake in the order as wrong flag image is displayed for each country:

image

and also, when I click on a particular flag in the flags of the world page, It takes me to the wrong country:

image image

drLite35 commented 7 months ago

It was highly possible for this to happen if you have time see where it is wrong I will also see for it.