Release v4

[JuiP]

• [x] The activity does not stop running. Fixed in 9ebc08d

• [x] Release the activity

Tested; no errors for me. @quozl @chimosky should I go ahead with release changes?

[quozl]

Thanks.

Tested eab3bf6 on Ubuntu 20.04. The toolbar is rendered, but the canvas is not.

By the way, new flake8 output added by your commits;

./run.py:141:80: E501 line too long (89 > 79 characters)
./run.py:145:80: E501 line too long (99 > 79 characters)
./run.py:149:80: E501 line too long (109 > 79 characters)
./crazyeights.py:34:1: F401 'sys' imported but unused

[JuiP]

@quozl I have made the suggested changes Also, I'll fix the new flake8 output added by my commits :)

[JuiP]

The NEWS file style is very different from what I saw in other activities. I have kept the original style unchanged. Kindly test, review and merge @quozl @chimosky

[quozl]

The toolbar is rendered, but the canvas is not. ^C gave me a traceback in pygame.camera.init; SystemError: bad call flags. This is on a VM under QEMU/KVM. The code has both a call to pygame.camera.init in run.py, and mentions pygame.camera in activity.py. I'm not sure why.

[JuiP]

@quozl I didn't get this error. I tried to investigate the cause this link might be useful. Which version of python3 and pygame are you using? Also, the canvas was not rendered before, I corrected the commit from eab3bf6 to 768c84a, the change in order seems to have fixed the issue for me.

[quozl]

Thanks. Also affects Pointillism activity. Ubuntu 20.04, Python 3.8.2, Pygame 1.9.6. We had this same problem once before in Pointillism, and we added an exception handler to ignore it. How do you propose to handle the problem?

[JuiP]

I looked at this commit in pointillism activity. I haven't tested that activity before, what does camera do in the activity. On the contrary, for this activity I don't think camera has any role to play at all. Can you confirm @srevinsaju @quozl ?

[chimosky]

Tested.

After finishing a game of two players, activity seems to refuse input, can't start a new game by clicking on number of players.

This shows in the logs,

1596904874.030057 ERROR root: Event queue full!
1596904874.047109 ERROR root: Event queue full!
1596904874.062764 ERROR root: Event queue full!
1596904874.080531 ERROR root: Event queue full!
1596904874.097409 ERROR root: Event queue full!
1596904874.113944 ERROR root: Event queue full!
Traceback (most recent call last):
  File "/home/ibiam/Activities/fifty-two-activity/sugargame/event.py", line 112, in _quit_cb
    pygame.event.post(pygame.event.Event(pygame.QUIT))
pygame.error: Event queue full
Traceback (most recent call last):
  File "/home/ibiam/Activities/fifty-two-activity/sugargame/event.py", line 109, in _screen_changed_cb
    self.update_display()
  File "/home/ibiam/Activities/fifty-two-activity/sugargame/event.py", line 98, in update_display
    pygame.event.post(pygame.event.Event(pygame.VIDEOEXPOSE))
pygame.error: Event queue full

[srevinsaju]

I looked at this commit in pointillism activity. I haven't tested that activity before, what does camera do in the activity. On the contrary, for this activity I don't think camera has any role to play at all. Can you confirm @srevinsaju @quozl ?

I will check this activity tomorrow, sorry for the delay

[JuiP]

@chimosky Thanks for noticing! Yes that does happen, looking up the code to find what might have caused this.

[quozl]

I looked at this commit in pointillism activity. I haven't tested that activity before, what does camera do in the activity. On the contrary, for this activity I don't think camera has any role to play at all. Can you confirm @srevinsaju @quozl ?

photo() is called under specific conditions by run(). I'm not familiar with the activity, but that's what the source code says. So the camera has some role, but I don't know what it is.

[JuiP]

Yes, I did look up the source code for this activity. However, I played the activity multiple times; I didnot encounter a situation where camera was used/ required.

[quozl]

Can you reverse engineer the condition that leads to photo() being called, and reproduce it? My guess is some feature that allows the backs of cards to be given an image.