sugarlabs / fifty-two-activity

GNU General Public License v2.0
0 stars 5 forks source link

Release V4 #9

Closed drLite35 closed 5 months ago

drLite35 commented 5 months ago

Special Thanks to @JuiP

Kindly review @walterbender @chimosky @quozl . For reference see the pr https://github.com/sugarlabs/fifty-two-activity/pull/5 Errors raised by @chimosky and @quozl are addressed.

This close https://github.com/sugarlabs/fifty-two-activity/issues/7. This close https://github.com/sugarlabs/fifty-two-activity/issues/6.

drLite35 commented 5 months ago

Also yes photo() plays a important role it helps in customising deck appearance.

drLite35 commented 5 months ago
drLite35 commented 5 months ago

Also I am sorry in advance, as I dont exactly know how some files like news etc are being edited so havent looked at them or how exactly version is changed, worked on this PR as all the issues can be solved.

chimosky commented 5 months ago

Reviewed 25213cf , not tested.

We have a maintainer checklist you should go through if you haven't.

This doesn't close #2, I'll upload the activity to weblate after this is merged.

drLite35 commented 5 months ago

Your commit message says Removed redundant self.running checks as in GUI interactions but there's no removal of any check instead there's removal of assignments.

Also avoid using ticks in git commit messages as git doesn't do any markdown formatting, you can use that in GH comments.

Assignment:

Checks:

Well I am unsure on the part because I took the sense of whole loop though if you want can change that to assignments.

drLite35 commented 5 months ago

Yes changes the commit message , Thanks!! Removed issue 2.

drLite35 commented 5 months ago

I guess then news can be updated later lets say when version 5 is launched with several other updates etc? @chimosky

chimosky commented 5 months ago

I guess then news can be updated later lets say when version 5 is launched with several other updates etc? @chimosky

The news file is updated as part of the release because that's what tells you what changed in that particular release.

drLite35 commented 5 months ago

Branch seem to have conflicts, Closing Thanks.