search

sugarlabs / flappy-birds-activity

An arcade game for Sugar XOs.
1 stars 13 forks source link

Port To Python 3 #22

Closed Creatune closed 4 years ago

Creatune commented 4 years ago

As the sugargame repo was already updated I didn't get any errors regarding that. I ported the other files to python 3 (it wasn't much). But while testing, when I click on the sound/microphone button on the top left of the activity, it gives an AttributeError. It gave the same error before porting as well. Please let me know if there is anything I can do about this. Thank you :)

Creatune commented 4 years ago

Also, it is giving an "UnboundLocalError: local variable 'event' referenced before assignment" both before and after porting. I tried to fix it but to no avail, so can you please help me out with this?

srevinsaju commented 4 years ago

Also, it is giving an "UnboundLocalError: local variable 'event' referenced before assignment" both before and after porting. I tried to fix it but to no avail, so can you please help me out with this?

@Creatune can you give the error message?

Tested, logs contains:

ALSA lib pcm.c 8526 : (sn_pcm_recover) underrun occurred
quozl commented 4 years ago

@Creatune, please don't report already known issues? :grin: Read both https://github.com/sugarlabs/flappy/issues/22 and https://github.com/sugarlabs/flappy/issues/21 for comments on the error. Known issues and any open pull requests must be checked before porting. See making sure the activity works properly before porting in the porting guide.

quozl commented 4 years ago

Also, if the sound button doesn't work, please fix it or create an issue if you won't fix it.