Added Mute button; Solved #21; Modified Quitting the game;

[aditya113141]

• Press M to mute/unmute game.
• Solved issue sugarlabs/flappy#21
• Changed wrong name in game description.
• Quitting by returning.

[quozl]

Thanks.

Functional test on Debian 11 (Bullseye). The speaker button does not have an accelerator label. The speaker button is not adjacent to the activity icon. Several AttributeError and PermissionError tracebacks are shown on standard error or logs. The M button does nothing during the Get Ready! screen. The Get Ready! screen consumes all available CPU time. After hitting object in play the game stops and cannot be restarted without using the Stop button. https://github.com/sugarlabs/flappy/issues/23 is reproduced.

On pressing the speaker button;

Traceback (most recent call last):
  File "/usr/share/sugar/activities/FlappyBirds.activity/activity.py", line 71, in sound_control
    button.set_icon('speaker-muted-000')
AttributeError: 'ToolButton' object has no attribute 'set_icon'
Traceback (most recent call last):
  File "/usr/share/sugar/activities/FlappyBirds.activity/activity.py", line 74, in sound_control
    button.set_icon('speaker-muted-100')
AttributeError: 'ToolButton' object has no attribute 'set_icon'
Traceback (most recent call last):
  File "/usr/share/sugar/activities/FlappyBirds.activity/activity.py", line 71, in sound_control
    button.set_icon('speaker-muted-000')
AttributeError: 'ToolButton' object has no attribute 'set_icon'
Traceback (most recent call last):
  File "/usr/share/sugar/activities/FlappyBirds.activity/activity.py", line 74, in sound_control
    button.set_icon('speaker-muted-100')
AttributeError: 'ToolButton' object has no attribute 'set_icon'
Traceback (most recent call last):
  File "/usr/share/sugar/activities/FlappyBirds.activity/main.py", line 150, in make
    self.birds.jump(land1, land2, self.land1x,
  File "/usr/share/sugar/activities/FlappyBirds.activity/elements.py", line 139, in jump
    b.run(g.gameDisplay, g.scores, sound)
  File "/usr/share/sugar/activities/FlappyBirds.activity/scorescreen.py", line 60, in run
    open('score.pkl', 'w+')
PermissionError: [Errno 13] Permission denied: 'score.pkl'

On collision with terrain;

Traceback (most recent call last):
  File "/usr/share/sugar/activities/FlappyBirds.activity/main.py", line 130, in make
    i.display(self.gameDisplay, self.pillarlist, self.birds,
  File "/usr/share/sugar/activities/FlappyBirds.activity/elements.py", line 67, in display
    b.run(g.gameDisplay, g.scores, sound)
  File "/usr/share/sugar/activities/FlappyBirds.activity/scorescreen.py", line 60, in run
    open('score.pkl', 'w+')
PermissionError: [Errno 13] Permission denied: 'score.pkl'

[quozl]

Please also review these commits to Stick Hero as they show the sort of problems that were fixed in porting to Python 3 and Sugargame 1.3. Both activities are by the same author, so the same problems arise.

Also compare with Flappy activity which fills the display better and otherwise seems to be the same game. Unless there's something unique about Flappy Birds, I'm not sure why we should spend the time on it instead of Flappy.

[aditya113141]

Pardon, I am not sure about the issue that popped up in Debian 11. Things seem to work fine on Raspberry Pi OS. I agree that Flappy activity is better than this one and there may not be any reason to spend time on this.