search

sugarlabs / grid-paint-activity

Other
0 stars 3 forks source link

Port to Webkit2 #4

Closed cemeiq closed 5 years ago

cemeiq commented 6 years ago

Port to Webkit2

cemeiq commented 6 years ago

@quozl please, review this.

chimosky commented 6 years ago

Reviewed, thanks. Remove the two new lines from the activity.info file, as they're not needed.

cemeiq commented 6 years ago

I have removed the two new lines from activity.info file @chimosky . Thanks

quozl commented 5 years ago

Reviewed to cfe490c. I'm curious. What's the vcs.xml file for?

cemeiq commented 5 years ago

Its Pycharm IDE's configuration file. Apologies. Removing it

quozl commented 5 years ago

Sorry for the delay, slowly getting through my 3500 mail messages. Was about to merge, but;

I have removed the two new lines from activity.info file @chimosky . Thanks

Please git add and git commit that? At the moment the pull request files changed tab shows the added lines.

quozl commented 5 years ago

Thanks. Reviewed. GitHub didn't show why enyo.py has a change in the first line, but a quick binary analysis showed me;

$ head -1 enyo.py | hexdump -C
00000000  ef bb bf 23 21 2f 75 73  72 2f 62 69 6e 2f 65 6e  |...#!/usr/bin/en|
00000010  76 20 70 79 74 68 6f 6e  0d 0a                    |v python..|
0000001a
$ git checkout 0d0e811
$ head -1 enyo.py | hexdump -C
00000000  23 21 2f 75 73 72 2f 62  69 6e 2f 65 6e 76 20 70  |#!/usr/bin/env p|
00000010  79 74 68 6f 6e 0d 0a                              |ython..|
00000017