search

sugarlabs / i-can-read-activity

GNU General Public License v3.0
1 stars 10 forks source link

Port to GTK3 #3

Open rhl-bthr opened 6 years ago

rhl-bthr commented 6 years ago

i-can-read is dependent on GTK+ 2 API and must be ported to GTK+ 3 API.

(Should anybody take this, please look at my work in progress. Remaining changes are porting drawing code to Cairo drawing code.)

yell0wfl4sh commented 6 years ago

@Pro-Panda status?

rhl-bthr commented 6 years ago

@yashagrawal3 As mentioned above, the port is partially complete. I am not currently working on the same. You may continue from my work in progress

yell0wfl4sh commented 6 years ago

@Pro-Panda OK! thanks.

yell0wfl4sh commented 6 years ago

WIP https://github.com/yashagrawal3/i-can-read-activity/tree/gtk3 Continued work from Pro-Panda's fork. page.py needs a lot of work, port to cairo left. Following similar changes as was made in https://github.com/sugarlabs/AEIOU/commit/4f7fad4635b1b5cef1295efa5d071e5c3a82619f @quozl suggestions are welcomed.

quozl commented 6 years ago

Reviewed, thanks. I wasn't sure what was happening. I suggest using smaller commits, and more of them, with brief description of why you changed something.

yell0wfl4sh commented 6 years ago

@quozl @chimosky spent another complete day on it, tried to port every line from start ended up getting the same error. I have tried by all means to solve this, I need some help on this issue. See my new branch: https://github.com/yashagrawal3/i-can-read-activity/tree/gtk3port

quozl commented 6 years ago

need some help on this issue.

Looks like you since fixed your problem with unexpected unicode strings in the generated SVG XML stream. However, some more work seems to be needed.

Adding missing link between pull request and issue; https://github.com/sugarlabs/i-can-read-activity/pull/8