Port to Gtk+ 3

[yell0wfl4sh]

Port to Gtk+3 is complete. Port of GStreamer is still left. If anyone can tell me how this activity was ideally meant to work, I will have a better idea fixing rest of the bugs. @quozl @walterbender @chimosky please review!

[quozl]

tell me how this activity was ideally meant to work

Use it as it was before you changed it, and read the documentation.

You can test using GTK+ 2 with the master branch, relying on the user documentation.

You should fix all critical problems with an activity before porting to GTK+ 3,

I did begin a review and test.

For review,

• commented code is not yet removed,
• the source of unicode strings is still not identified, and it seems likely that you have added str() calls to places that might not need them; in my experience, the most likely cause of unicode strings is the profile.get_colors() call you've added; and I can't figure out why you added that.
• GStreamer video handling code should not be here; it was a hasty copy from the Record activity; do not port this, just remove code that isn't called.

So I don't think this pull request is ready for detailed code review.

For test,

• the appearance of the activity is unlike how it used to appear; the text is missing, and the background of screen has taken on user colour; please get the master branch running with GTK+ 2 to see how it should appear,
• the record and play features don't work, and there is a traceback;

Traceback (most recent call last):
  File "/usr/share/sugar/activities/ICanRead.activity/ICanReadActivity.py", line 485, in _playback_recording_cb
    'output.ogg'))
  File "/usr/share/sugar/activities/ICanRead.activity/utils/gplay.py", line 50, in play_audio_from_file
    lc.gplay = Gplay(lc, lc.tw.canvas.width, lc.tw.canvas.height, 4, 3)
AttributeError: Page instance has no attribute 'tw'

Also noted a few other things during review of master branch;

• dist_xo does not work
• a different audio recording traceback
• icon missing which it turns out you have fixed in 2d5559279a19ecde8c9ad9a4f1ee997339005e61 (though your commit message didn't say what you had done or why).

[rhl-bthr]

Stale, closing