Fix function calls while retrieving Wikipedia content

sugarlabs / infoslicer

GNU General Public License v2.0

2 stars 10 forks source link

Fix function calls while retrieving Wikipedia content #27

Closed nswarup14 closed 5 years ago

nswarup14 commented 5 years ago

Files Changed 1) .gitignore 2) MediaWiki_Helper.py 3) MediaWiki_Parser.py

Description 1) In the ./infoslicer/processing/MediaWiki_Helper.py, several methods calls that primarily aid in retrieving and parsing content from Wikipedia articles did not contain self.

Tested on Ubuntu 18.04, Sugar v0.112, using rDesktop

Aniket21mathur commented 5 years ago

Thanks.Reviewed.Please write a meaningful commit message including why you made the following changes. Please see our guide to commit messages . From code analysis I am able to draw the following conclusions:

You removed the unused functions from infoslicer/processing/MediaWiki_Helper.py as they were not called anywhere in the code.
You imported NoDocException in infoslicer/processing/MediaWiki_Parser.py as it was used in the code.
You added self in function calls.

quozl commented 5 years ago

@nswarup14, thanks. @Aniket21mathur, agreed. I did review this earlier but couldn't summarise as well as you have, so I'll use your commit message. I'll take squashing and merging as my responsibility to do anything trivial.