search

sugarlabs / jumble-activity

GNU General Public License v3.0
0 stars 6 forks source link

v23 #10

Closed JuiP closed 4 years ago

JuiP commented 4 years ago

Help needed @quozl @chimosky : I'm confused, activity/activity.info mentions activity_version = 22 but there are no git tags or a NEWS file. Also I don't see po folder with translation files and the activity is not a project under https://translate.sugarlabs.org/

I was referring to the maintainer's list

chimosky commented 4 years ago

I'm guessing the activity was moved from it's gitorious instance but I can't find the activity repo and it's also not on sunjammer. When the repo was created, other measures weren't taken. Maybe @quozl can help, I can't remember where the OLPC git instance was else I would have checked there too.

quozl commented 4 years ago

The author was Peter Hewitt, and he made bundles and did not use git. There was no requirement to use git.

This repository does not follow our conventions on tags or commit history. Look at the commit history and you'll see Tony Anderson built this repository by unpacking the zip file bundles of older versions of the activity.

JuiP commented 4 years ago

This repository does not follow our conventions on tags or commit history. Look at the commit history and you'll see Tony Anderson built this repository by unpacking the zip file bundles of older versions of the activity.

So does this mean we don't release this activity like other activities? I haven't released activities before so might have few questions initially.

For releasing the activity,

Is this all/ I have skipped something I should know?

quozl commented 4 years ago

Won't really know if you've skipped something until we get to review a pull request. :grin:

Sugar Labs hasn't released this activity despite the great work by @pipix51 (2017), @yashagrawal3 (2018), and @pro-panda (2018). And now you've worked on it. Thanks!

Missing a complete commit history (because there wasn't one), or version tags (because nobody made any), doesn't preclude the remainder of the maintainer checklist.

You have attempted to correlate the tags (none) with the activity_version. That won't stop you from creating a tag, or updating the version.

Likewise you can't "apply any translate.sugarlabs.org changes" because there aren't any, in turn because the activity has not been set up for translation. I've looked briefly at the source code, and can't see anything that needs to be translated.

I suggest creating a NEWS file with a summary of the changes made since v22.

You can also add tags for the previous versions; see man git tag for how to do that. Tagging isn't covered by pull requests though.

JuiP commented 4 years ago

@chimosky @quozl kindly review. I think we should keep updating host_version instead of activity versions for activities like these. The NEWS file can then include all changes made to the activity after it was added as a sugarlabs activity. What do you think?

quozl commented 4 years ago

Thanks. But I don't think you understood what _hostversion was for. It was for declaring the compatible version of OLPC OS, so that bundles won't be installed where they cannot run. The idea was to increment this number in Sugar when a breaking change to the API happened, and then change it in activities that complied with that breaking change.

Hope that helps!

JuiP commented 4 years ago

Thanks! @quozl Looking at the links you shared, it seems like _hostversion no longer required. Do you think I should remove it from the activity.info file?

chimosky commented 4 years ago

Thanks! @quozl Looking at the links you shared, it seems like _hostversion no longer required. Do you think I should remove it from the activity.info file?

Yes you should remove it.

chimosky commented 4 years ago

Reviewed, thanks.

Waiting for @quozl to confirm merge.