search

sugarlabs / jumble-activity

GNU General Public License v3.0
0 stars 6 forks source link

Replace flashing anim with smooth sliding anim. #14

Closed sparshg closed 2 years ago

sparshg commented 2 years ago

@chimosky @srevinsaju @quozl Please review, Thanks.

chimosky commented 2 years ago

Reviewed and tested, works as expected.

chimosky commented 2 years ago

For future purposes, could you avoid force pushing commits as it's helpful to see your thought process while working on an issue.

You can have multiple commits as you can use the commit message and help whoever sees it understand better, everything doesn't have to be in one commit.

The perfect example would be your change in your recent commit where you've created an easing_func function, a different commit would've been preferred.

I'll merge this now but please for future PRs, you can split your commits whenever a change is requested.

sparshg commented 2 years ago

oh okay, I don't prefer rewriting the commits but I was told so in my first PR in block party activity. I revisited that now and realised that I was asked to rewrite commit only for a 'revert' commit. I will keep that in mind though. \:D

chimosky commented 2 years ago

I'm also not asking you to rewrite commits, I'm asking you to add commits when there's another change instead of squashing and force pushing.