sugarlabs / maze-activity

A simple maze game for the Sugar learning environment
GNU General Public License v3.0
1 stars 10 forks source link

Update Metadata + Screenshots (Revised) #24

Closed Ashnidh closed 5 years ago

Ashnidh commented 6 years ago

As per the suggestion by @vipulgupta2048 in pull request #23 , I have updated the metadata and renamed the screenshots.

vipulgupta2048 commented 6 years ago

Also, please don't make new PR's with every change as it becomes very difficult to review pull requests back and forth.

Ashnidh commented 6 years ago

Also, please don't make new PR's with every change as it becomes very difficult to review pull requests back and forth.

Ok Sir. Thank you

Ashnidh commented 6 years ago

Thank you. Done.

quozl commented 6 years ago

Thanks. Reviewed.

You can work around these last two points; use a virtual machine and set the display resolution of the virtual window to 1024x768 (one of the VESA sizes), then capture the screenshot.

Ashnidh commented 6 years ago

Thanks. Reviewed.

  • [ ] your screenshots metadata links to your own repository instead of Sugar Labs; this will break once you delete your repository, and it would enable your control of the screenshots without review,
  • [ ] none of your screenshots show the critical feature of the Maze activity; collaboration between multiple instances of Sugar, with multiple players shown,
  • [ ] the first and second screenshots show a bug with calculation of dimensions of the maze on a display resolution of 1366x768; see how there is a wider black border on the left of the maze than on the right; are you willing to fix this in the code, or shall we create a tracking issue for someone else to look at it?
  • [ ] our other screenshots are mostly in 4:3 aspect ratio, so your 16:9 screenshots would look out of place.

You can work around these last two points; use a virtual machine and set the display resolution of the virtual window to 1024x768 (one of the VESA sizes), then capture the screenshot.

Sir, I have captured screenshots in 4:3 aspect ratio using a virtual machine and replaced them with the older ones. I have updated screenshots metadata links to Sugar Labs repository. Regards

quozl commented 6 years ago

Thanks. Good progress.

screenshot_ubb_2018-11-13_11 29 03

What version of Sugar and Linux are you using? Is there anything in /home/$USER/.sugar/default/logs/ that might explain why the icon is missing?

Ashnidh commented 6 years ago

Thanks. Good progress.

  • [ ] Multiple players aren't shown; there should be more than one smiley face in the maze. On the other hand, I'm having trouble getting this to work at the moment, so there may be an underlying problem. There's nothing in logs.
  • [ ] The description menu item in the activity menu is missing an icon; that's the element to the right of "Maze activity" and to the left of the sharing button. Here's what it looks like for me, on Ubuntu 18.04 with Sugar 0.112;

screenshot_ubb_2018-11-13_11 29 03

What version of Sugar and Linux are you using? Is there anything in /home/$USER/.sugar/default/logs/ that might explain why the icon is missing?

I am getting the same again as shown in the screenshot. I am using Sugar 0.112 on a virtual machine with OS Linux version openSUSE (64-bit) Regards

quozl commented 6 years ago

Thanks. Is there anything in /home/$USER/.sugar/default/logs/ that might explain why the icon is missing? In particular look at shell.log and the maze activity log.

Ashnidh commented 6 years ago

Thanks. Please find enclosed the screenshots of data found in /home/liveuser/.sugar/default/logs/ Regards

1 2 3 4 5 6 7 8 9 10 11

quozl commented 6 years ago

Thanks. None of the logs were related to a missing icon. I've no idea why you have a missing icon. I don't have a copy of openSUSE and don't have the resources to get one at the moment.

If you wish to diagnose further;

If something like this is going wrong in the toolkit, it would be good to fix it. Perhaps it is related to a newer version of GTK+.

Does the same problem happen for you at larger display dimensions?

If you don't have time to work on this, you might try Sugar Live Build or Fedora SoaS instead for making your screenshot.

rhl-bthr commented 5 years ago

Stale.

@Ashnidh in case you plan to work on it again, please feel free to open a new PR