search

sugarlabs / maze-activity

A simple maze game for the Sugar learning environment
GNU General Public License v3.0
1 stars 10 forks source link

Port to Python 3 #29

Closed Aniket21mathur closed 4 years ago

Aniket21mathur commented 5 years ago

Tested with toolkit-gtk3 v0.114.

rhl-bthr commented 5 years ago

Did you test for collaboration?

Add this to your test checklist for porting

Aniket21mathur commented 5 years ago

Yes tested collaboration with Ubuntu 18.04 using rdesktop. Works fine. Thanks!

quozl commented 5 years ago

But not with TelepathyGLib in Toolkit, right? If so, your test is with a combination of static binding to Telepathy in the Toolkit and TelepathyGLib in the activity, in the same process context.

Aniket21mathur commented 5 years ago

Yes @quozl . I tested with toolkit having Telepathy bindings with TelepathyGlib in the activity.

quozl commented 5 years ago

Okay, thanks. Let's wait for TelepathyGLib in the Toolkit before testing.

Aniket21mathur commented 5 years ago

@quozl @pro-panda please review and test. Thanks!

quozl commented 5 years ago

But there are conflicts?

Aniket21mathur commented 5 years ago

Rebased with master :sweat_smile: . Thanks!

quozl commented 5 years ago

Tested. There's an appearance regression. Maze cells are drawn with a border. Like this;

maze-2

Before this pull request the cell borders do not appear.

Aniket21mathur commented 5 years ago

Thanks, able to reproduce. Though I reviewed my changes and they doesn't seems to cause this. A shift to Python 3 might be causing it. I am working to figure out the cause.

chimosky commented 5 years ago

Tested, I get this error.

Traceback (most recent call last):
  File "/usr/local/bin/sugar-activity", line 5, in <module>
    activityinstance.main()
  File "/usr/local/lib/python2.7/dist-packages/sugar3/activity/activityinstance.py", line 230, in main
    instance = create_activity_instance(activity_constructor, activity_handle)
  File "/usr/local/lib/python2.7/dist-packages/sugar3/activity/activityinstance.py", line 59, in create_activity_instance
    activity = constructor(handle)
  File "/home/ibiam/Activities/maze-activity/activity.py", line 48, in __init__
    self.game = game.MazeGame(self)
  File "/home/ibiam/Activities/maze-activity/game.py", line 72, in __init__
    player = Player(activity.owner)
  File "/home/ibiam/Activities/maze-activity/player.py", line 37, in __init__
    self.nick = unicodedata.normalize('NFC', name)
TypeError: normalize() argument 2 must be unicode, not str
quozl commented 5 years ago

Not a fair test, you used Python 2.7, and you should use Python 3.

chimosky commented 5 years ago

Tested. There's an appearance regression. Maze cells are drawn with a border. Like this;

maze-2

Before this pull request the cell borders do not appear.

The cell borders disappear when the player passes it and comes back.

quozl commented 5 years ago

Thanks for testing.

quozl commented 4 years ago

Later pull request https://github.com/sugarlabs/maze-activity/pull/31 has progressed further.