search

sugarlabs / memorize-activity

A memory game, not only to play but also to create you own games, for the Sugar learning environment
GNU General Public License v2.0
1 stars 15 forks source link

Port speak/ to sugar3.speech #20

Closed nswarup14 closed 5 years ago

nswarup14 commented 5 years ago

Fixes #8 Please review

quozl commented 5 years ago

Thanks. Briefly reviewed. Looks fine apart from a trivial source code style problem that I can fix. Will test and review in full on Monday.

quozl commented 5 years ago 
Traceback (most recent call last):
  File "/usr/share/sugar/activities/Memorize.activity/createcardpanel.py", line 485, in _usespeak_cb
    button.palette.face.say(self.get_text())
  File "/usr/share/sugar/activities/Memorize.activity/speak/face.py", line 160, in say
    self.speech.say_text(self._peding or self.status, something)
  File "/usr/lib/python2.7/sugar3/speech.py", line 271, in say_text
    self._player.speak(pitch, rate, voice_name, text)
  File "/usr/lib/python2.7/sugar3/speech.py", line 381, in speak
    if not [i for i in text if i.isalnum()]:
TypeError: iteration over non-sequence
rhl-bthr commented 5 years ago

Stale. Closing