Port speak/ to sugar3.speech

[ghost]

Port to sugar3.speech from espeak in sugarlabs/memorize-activity/speak/

Fixes #8

Please review

[nswarup14]

I feel that you have used my PR to make your changes. I request you to credit me as a co-author in your commit. Thank you.

[ghost]

@nswarup14 Sure :)

[quozl]

Thanks. Good start. Reviewed 8a9c493.

• [x] please continue and finish the pull request; the activity doesn't start, which means you've left out changes that are critical,
• [x] include information about your test environment in the commit message; such as distribution of Linux and version of Sugar used,
• [ ] you have created three variables to hold copies of the SpeechManager object; is there a reason why you didn't use one?
• [x] numerous new whitespace and indentation problems, see below

$ python -m flake8 .
./speak/face.py:43:20: E225 missing whitespace around operator
./speak/face.py:91:20: E225 missing whitespace around operator
./speak/face.py:97:1: W293 blank line contains whitespace
./speak/face.py:99:9: E303 too many blank lines (3)
./speak/voice.py:113:11: E225 missing whitespace around operator
./speak/voice.py:114:15: E225 missing whitespace around operator
./speak/voice.py:115:8: E225 missing whitespace around operator
./speak/voice.py:116:1: W293 blank line contains whitespace
./speak/voice.py:117:18: E231 missing whitespace after ','
./speak/voice.py:117:23: E231 missing whitespace after ','
./speak/voice.py:119:13: E265 block comment should start with '# '
./speak/voice.py:121:1: W293 blank line contains whitespace
./speak/voice.py:128:1: W293 blank line contains whitespace
./speak/voice.py:129:29: E231 missing whitespace after ','
./speak/voice.py:129:34: E231 missing whitespace after ','
./speak/voice.py:130:1: W293 blank line contains whitespace
./speak/voice.py:131:21: E231 missing whitespace after ','
./speak/voice.py:131:26: E231 missing whitespace after ','
./speak/voice.py:135:1: W293 blank line contains whitespace
./speak/voice.py:136:1: W293 blank line contains whitespace

[ghost]

Fixed the indentation problems and tested.Sorry for such a long delay,had problems setting up a development environment. Please review

[quozl]

Thanks. Good progress.

• [ ] tested 368c481 on Ubuntu 18.04, there is no sound, and the speak button does not pop back out; please fix this;

Traceback (most recent call last):
  File "/usr/share/sugar/activities/Memorize.activity/createcardpanel.py", line 485, in _usespeak_cb
    button.palette.face.say(self.get_text())
  File "/usr/share/sugar/activities/Memorize.activity/speak/face.py", line 160, in say
    self.speech.say_text(self._peding or self.status, something)
  File "/usr/lib/python2.7/sugar3/speech.py", line 271, in say_text
    self._player.speak(pitch, rate, voice_name, text)
  File "/usr/lib/python2.7/sugar3/speech.py", line 381, in speak
    if not [i for i in text if i.isalnum()]:
TypeError: iteration over non-sequence

It looks familiar. It is the same problem as 03461e0 that I wrote about on https://github.com/sugarlabs/memorize-activity/pull/20. Did you review that pull request?

Also, I see that 03461e0 by @nswarup14 correctly removed import speak.espeak from face.py and createcardpanel.py; have you tested these too?

[ghost]

When I made the changes to speak/,I didn't realise that I'd have to run python setup.py install again.That means that I what I tested was the older version of speak/ that used espeak.So first of all sorry for mess and second when I do runpython setup.py install again it throws this error- https://pastebin.com/raw/0UBTmzw9 .So now I'm stuck,any suggestions on where to go from here? Thankyou

[quozl]

Using python setup.py install during development is okay as a test method, but you must first delete the destination directory. Otherwise any files you delete in your repository won't be deleted in the destination directory. The install step is intended for use by packagers of Linux distributions, where the destination directory is always empty. You can use it, but beware of limitations.

It is more common to either;

• do your testing from within Sugar, in the Terminal activity; cd to your repository, then type sugar-activity to run the activity (or sugar-activity-web to run a JavaScript activity), or
• use python setup.py dist_xo, look in dist/ directory for the bundle, and then install the bundle using Browse or the Terminal command sugar-install-bundle, then run it from the Sugar home view.

The error you saw from install;

Traceback (most recent call last):
  File "setup.py", line 21, in <module>
    bundlebuilder.start()
  File "/usr/lib/python2.7/dist-packages/sugar3/activity/bundlebuilder.py", line 629, in start
    globals()['cmd_' + options.command](config, options)
  File "/usr/lib/python2.7/dist-packages/sugar3/activity/bundlebuilder.py", line 509, in cmd_install
    installer.install(options.prefix, options.install_mime, options.install_desktop_file)
  File "/usr/lib/python2.7/dist-packages/sugar3/activity/bundlebuilder.py", line 311, in install
    shutil.copy(source, dest)
  File "/usr/lib/python2.7/shutil.py", line 133, in copy
    copyfile(src, dst)
  File "/usr/lib/python2.7/shutil.py", line 96, in copyfile
    with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: '/home/mayank/memorize-activity/speak/espeak.py'

means that git ls-files lists speak/espeak.py, but there is no such file in your repository. I can't explain how you did that. git status can confirm it. My best guess is you have changed your repository state in some way such that it is different to the branch associated with this pull request.

[rhl-bthr]

@nswarup14 @mk1299 Will you be continuing to work on this ?

[ghost]

@pro-panda Yes I will continue working on this.

[rhl-bthr]

Stale, closing