Redesign the 5X5 game layout for symmetry

sugarlabs / memorize-activity

A memory game, not only to play but also to create you own games, for the Sugar learning environment

GNU General Public License v2.0

1 stars 15 forks source link

Redesign the 5X5 game layout for symmetry #24

Closed nswarup14 closed 4 years ago

nswarup14 commented 4 years ago

Implements #17

Changes 1) cardtable.py 2) model.py 3) game.py

Updates For the 5X5 tile page, I have added an inactive black tile at the center of layout. The black tile is unresponsive to any event/signal and thus completely inactive. This ensures that the layout is symmetrical.

Testing 1) I haven't yet tested the above feature on collaboration. I shall do that soon. I invite others to test the changes as well.

Thanks!

Tested on Ubuntu 18.04 and Sugar v0.114

Aniket21mathur commented 4 years ago

Thanks. Tested. Introducing a black square in the middle of the grid for odd dimensions make it look better and uniform. :-)

rhl-bthr commented 4 years ago

Thanks. Reviewed. @Aniket21mathur Did you test for collaboration ?

rhl-bthr commented 4 years ago

Fixes #24 Link PR to issue for auto-closing

quozl commented 4 years ago

Thanks. Tested as at 764ceff.

[x] the new empty square is too remarkable; please use same background colour in both the new empty square and the game board canvas.

Did not test collaboration.

Code review as at 764ceff. Nothing to report.

nswarup14 commented 4 years ago

@quozl I have changed the color to the same that of the game board canvas.

quozl commented 4 years ago

Reviewed. Tested collaboration.

quozl commented 4 years ago

Implements #17

@nswarup14, please use "Fixes" instead of "Implements", so as to trigger automatic close of issue.