search

sugarlabs / musicblocks-v4

A complete overhaul of Music Blocks
http://www.sugarlabs.org/music-blocks/
GNU Affero General Public License v3.0
76 stars 103 forks source link

Verify TypeScript Types Failure! #375

Open Sumit-pd opened 10 months ago

Sumit-pd commented 10 months ago

This issue is in context with #369 There are only documentation changes in the above pr still the verify typescript fails. The logs on my local are shown below. sugarlabs sugarlsb2

The Linting passes on my local, but it fails on GitHub. Here are the logs Screenshot from 2023-12-25 10-15-44

comment: The reason for verify typescript is that _state , _defaultSynth and _polySynth from Voice.tsx are imported from singer.ts but they are not exported from singer.ts @walterbender Take a look on this and tell me how should I proceed!

walterbender commented 10 months ago

I think you should make them exportable as per your earlier PR (but as a separate PR). But while you are doing that you should remove the _ from the variable names as they are not internal.

ThisisMS11 commented 6 months ago

is this issue still relevant ?