Open Sumit-pd opened 6 months ago
I think you should make them exportable as per your earlier PR (but as a separate PR). But while you are doing that you should remove the _ from the variable names as they are not internal.
is this issue still relevant ?
This issue is in context with #369 There are only documentation changes in the above pr still the verify typescript fails. The logs on my local are shown below.
![sugarlsb2](https://github.com/sugarlabs/musicblocks-v4/assets/88550925/18f86917-3beb-4ebf-b779-17b28144c609)
The Linting passes on my local, but it fails on GitHub. Here are the logs![Screenshot from 2023-12-25 10-15-44](https://github.com/sugarlabs/musicblocks-v4/assets/88550925/14d9821a-8749-4b19-b792-8eb301727711)
comment: The reason for verify typescript is that _state , _defaultSynth and _polySynth from Voice.tsx are imported from singer.ts but they are not exported from singer.ts @walterbender Take a look on this and tell me how should I proceed!