Better Faux Pickup Support

[pikurasa]

Music Blocks does not mind unusual pickups of 1/3, but Lilypond does not support this sort of input.

In fact, if you put a pickup of 1/3 in your code, Lilypond export fails.

Uncaught ReferenceError: obj is not defined
    at Notation.notationPickup (notation.js:322)
    at Function.setPickup (MeterActions.js:64)
    at PickupBlock.flow (MeterBlocks.js:792)
    at Logo.runFromBlockNow (logo.js:1603)
    at logo.js:1477

Test File: Faux-Pickup.html.zip

For more information on how we can formulate a "faux pickup" in MB, please see https://github.com/sugarlabs/musicblocks/issues/1086#issuecomment-368234124

[kushal-khare-official]

@pikurasa What should be the expected behavior? What pickup should lilypond not support?

Current Behavior: After a small fix, though saving this file as lilypond shows an error, it still downloads it. Faux-Pickup.pdf Here's the pdf file generated by lilypond

[pikurasa]

After a small fix,

What was your small fix? It seems to involve be deleting the "pickup" block.

though saving this file as lilypond shows an error, it still downloads it. Faux-Pickup.pdf

(I am guessing, but it seems) You deleted the ~.

[pikurasa]

What should be the expected behavior?

The expected behavior is to be able to generate a lilypond file regardless of the values a MB user puts in for their pickup.

Lilypond has no (direct) support for tuplet values (e.g. 3, 5, 7, etc.). Therefore, we would need to finagle our lilypond output to make it work in lilypond.

[kushal-khare-official]

What was your small fix?

I just declared the variable. See this commit

[pikurasa]

I just declared the variable. See this commit

Ok, but it doesn't fix this issue.

[kushal-khare-official]

Lilypond has no (direct) support for tuplet values (e.g. 3, 5, 7, etc.). Therefore, we would need to finagle our lilypond output to make it work in lilypond.

But it did generate a .ly file regardless of the values. Please check if the this fileFaux-Pickup.pdf is as expected. If it is then we only need to make sure that it does not show any error msgs.

[pikurasa]

@kushal-khare-official Do you know what a pickup measure is?

[pikurasa]

Please check if the this fileFaux-Pickup.pdf is as expected.

(No, this is not as expected. This is the second time I have looked at this same file.)

[ashutosh887]

@walterbender @pikurasa Should I work on it if it's still not resolved? Please assign this issue to me!

[walterbender]

We don't assign issues, but feel free to make a PR.

[pikurasa]

@MohitGupta14 I haven't tested this in a while, so I recommend to test once before starting it. Please use the test file in the original report. Happy to help explain what this means musically speaking.

[Shyam-Raghuwanshi]

@pikurasa can i work on this issue

[pikurasa]

@pikurasa can i work on this issue

Yes, you may (no one need ask permission here). Do you have any questions about the issue itself?