sugarlabs / musicblocks

Music Blocks -- A musical microworld
https://musicblocks.sugarlabs.org/
GNU Affero General Public License v3.0
539 stars 727 forks source link

Enhance the search bar ui #3822

Closed Haile-08 closed 3 months ago

Haile-08 commented 3 months ago

Fixed Issue #3804

Behavior Before Fix

Currently , on clicking the search bar in the website , a new search box is created which is slightly larger than the original search box and overlaps with the pre-existing one , which does not look very useful or necessary in the UI.

orginal.webm

Behavior After Fix

Remove the current functionality of creating a new search box and use the existing default search box to search blocks. If the size doesn't seem sufficient , the increase of the size of the entire left palette can be proposed.

fix.webm

Edited File Location

MUSICBLOCKS
├── CSS
│   ├── activities.css

Edited Code

#search[type="text"] {
  width: 80px;
  box-sizing: border-box;
  position: absolute;
  background-color: white;
  background-repeat: no-repeat;
  padding: 6px 10px 6px 10px;
  -webkit-transition: width 0.4s ease-in-out;
  transition: width 0.4s ease-in-out;
  font-size: 16px;
  margin-top: 4px;
  color: black;
}

#search:focus {
  border: 1px solid #87cefa;
  border-radius: 1px;
}

Checklist

pikurasa commented 3 months ago

The search doesn't seem to work for me. And it is more important that the search works than having it look nice...

Screenshot from 2024-03-15 12-18-36 Screenshot from 2024-03-15 12-18-31 Screenshot from 2024-03-15 12-18-23

Are you able to make it both look nice and work?

Haile-08 commented 3 months ago

the functionality was not implemented but i will work on it :)

Haile-08 commented 3 months ago

@pikurasa should I create an issue or work on this branch?

pikurasa commented 3 months ago

Whereas work for this is continuing on https://github.com/sugarlabs/musicblocks/pull/3829, I am closing this PR. Reopen if I am mistaken.