Bugs in Temperament Block

falgun143 commented 3 months ago

Description

There are mutilple bugs in the present temperament block 1.When ever the time difference between two clicks on the play/stop button is less then a new playback is generated which results in collision of the music 2.When we click on the pause button the next note is also highlited.

When the notes are played in reverse order and when we click on pause button the note still remain highlited .

Expected Behavior

1.When ever the time difference between two clicks on the play/stop button is less then either of the two should happen 1.1 If the note was still playing then it should resume from where it stopped. 1.2 And if the note is completed then it should again start from zero.

2.When we click on the pause button the next note should not get highlited.

When the notes are played in reverse order and when we click on pause button the note should have the initial color .

Screenshots

These are the video's showing all the bugs

1. https://github.com/sugarlabs/musicblocks/assets/105922142/0e465a45-fed1-4dc8-b9c9-59568a9fe970

2. https://github.com/sugarlabs/musicblocks/assets/105922142/41694dd1-5aa2-4902-9267-55f29bd0a842 3.

https://github.com/sugarlabs/musicblocks/assets/105922142/e67cd5c7-d410-4667-b5f3-01a04cf2adad

How to Reproduce

Switch to advanced mode and select temperament.

Console log Errors:

Environment:

Operating System: [e.g., Windows, macOS, Linux]
Browser (if applicable): [e.g., Chrome, Firefox, Safari]
Version of Software/Project: [e.g., v1.0.0]

Checklist

[ ] I have read and followed the project's code of conduct.
[ ] I have searched for similar issues before creating this one.
[ ] I have provided all the necessary information to understand and reproduce the issue.
[ ] I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

pikurasa commented 3 months ago

These improvements all seem good to me. @falgun143 do you plan to work on them, or are you just reporting them? (Just reporting is fine, too)

falgun143 commented 3 months ago

@pikurasa I have almost done ,Will raise a pr soon.

sugarlabs / musicblocks