silence block collapse issue

[walterbender]

Description

Expected Behavior

The "undefined" should not be there

How to Reproduce

Drag a silent note (rest) off of the Note Values palette and collapse it.

Checklist

• [x] I have read and followed the project's code of conduct.
• [x] I have searched for similar issues before creating this one.
• [x] I have provided all the necessary information to understand and reproduce the issue.
• [x] I am willing to contribute to the resolution of this issue.

---

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

[Ashish020202]

@walterbender in my case after collapse it looks like this

[walterbender]

That is a different somewhat unrelated bug. Sometimes the shape bounding box doesn't seem to update properly.

[Ashish020202]

yes, it seems to be, maybe another ticket for this. when I choose 1/8 then undefined is there but in the case of 1/4 it is right?? I checked with other values as well I think only in the case of 1/8 there is an issue.

[walterbender]

I haven't looked at the code yet, but I suspect from your analysis that it is a problem with the 1/8 note rest symbol.

[Mubashirshariq]

for 1/16 also i am getting undefined

[walterbender]

The problem is in musicutils.js there are no symbols defined for 1/8 and 1/16 rests. If there are no such symbols, we should use "".

[walterbender]

There are unicode symbols for those rest values so we should use them. 1/8 rest: "𝄾" 1/16 rest: "𝄿"

[khadar1020]

Is this correct sir @walterbender

Thank you

[walterbender]

If/when we add more symbols to the NSYMBOLS list, we need to add corresponding symbols to the RSYMBOLS list. but I think we really don't need those uncommon symbols.