sugarlabs / musicblocks

Music Blocks -- A musical microworld
https://musicblocks.sugarlabs.org/
GNU Affero General Public License v3.0
539 stars 727 forks source link

Added musical example of double sharps and flats #3855 #3872

Open byoojh opened 2 months ago

byoojh commented 2 months ago

Added a section in the guide under the sharps and flat to describe use cases of double sharps and flats, along with some well known musical examples.

pikurasa commented 2 months ago

I'm assuming this is ready for review, so I'm checking it out.

pikurasa commented 2 months ago

It's going well so far. Two comments:

  1. Accidentals

In addition to using the "accidental override", I think you should add examples of selecting those accidentals from the pie menu as follows:

Screenshot from 2024-04-22 16-00-19 Screenshot from 2024-04-22 16-01-18 Screenshot from 2024-04-22 16-01-32

  1. Left/right

In the text, it refers to examples on the left and right. However, they display for me above and below. Perhaps just refer to them as first and second example, or, if you can, add captions underneath and refer to them as "the example by Liszt" and "the example by Bartok".

Screenshot from 2024-04-22 16-02-37