sugarlabs / musicblocks

Music Blocks -- A musical microworld
https://musicblocks.sugarlabs.org/
GNU Affero General Public License v3.0
539 stars 726 forks source link

Issue with old-style sharp block #3891

Closed pikurasa closed 1 month ago

pikurasa commented 1 month ago

Description

Lilypond export and playback fails for certain projects.

After some testing, I believe it is specific to the old-style "sharp" accidental block.

Screenshots

Screenshot from 2024-05-14 10-18-23

How to Reproduce

I ran into this issue when trying to demonstrate MB's Lilypond export feature to someone. I used the Doraemon project that's in the example folder, and it wouldn't complete the save.

I believe the issue is caused by the older style of accidental blocks, and, specifically, with the sharp block (as in the image above). I tested with both the old flat and sharp blocks, and it only surfaced with the sharp block.

Console log Errors:

Uncaught TypeError: Singer.PitchActions.setSharp is not a function
    at SharpBlock.flow (PitchBlocks.js:1531:33)
    at Logo.runFromBlockNow (logo.js:1453:54)
    at logo.js:1300:32

Screenshot from 2024-05-14 10-09-06

This is a version of the Doraemon project that targets testing to a section that has the old-style sharp block: old-style-sharp.zip