search

sugarlabs / musicblocks

Music Blocks -- A musical microworld
https://musicblocks.sugarlabs.org/
GNU Affero General Public License v3.0
539 stars 726 forks source link

setsharp pitch action #3893

Closed Aman1919 closed 1 month ago

Aman1919 commented 1 month ago

issue - https://github.com/sugarlabs/musicblocks/issues/3891 In this PR, setSharp was invoked within pitchblock but hasn't been declared in pitchaction https://github.com/sugarlabs/musicblocks/pull/2454

After fixing

https://github.com/sugarlabs/musicblocks/assets/89124765/c5f139fc-4509-40f8-b167-b15d440f5b97

Aman1919 commented 1 month ago

@pikurasa @walterbender you review this . Thank you

walterbender commented 1 month ago

It may be better to implement a solution similar to the flatBlock in js/blocks/PitchBlocks.js

Aman1919 commented 1 month ago

@walterbender i have implemented it in pitchblocks.js