sugarlabs / musicblocks

Music Blocks -- A musical microworld
https://musicblocks.sugarlabs.org/
GNU Affero General Public License v3.0
558 stars 757 forks source link

Y's zero changes in relationship to grid when recording #3913

Closed pikurasa closed 3 months ago

pikurasa commented 3 months ago

Description

When you use the screen-record feature in MB, the zero for y changes in relation to grid. This is problematic for projects that use grid.

This most likely has to do with the fact that when you record the height of the frame changes (see images).

Expected Behavior

Point zero of Cartesian and middle-c of the staff should match point zero when a user is recording.

Screenshots

With grand staff, before recording: Screenshot from 2024-06-23 07-31-49

With grand staff, after recording: Screenshot from 2024-06-23 07-32-03

With Cartesian grid, before recording: Screenshot from 2024-06-23 07-35-42

With Cartesian grid, after recording: Screenshot from 2024-06-23 07-45-00

This is a test that shows that MB thinks the misaligned location is zero (to rule out other possible sources of the issue): cartesian-grid-record-test.webm

How to Reproduce

See above images.

Environment:

walterbender commented 3 months ago

I think your diagnosis is correct. The "sharing this tab" message that causes the change in screen size is generated by the browser, not MB, so we'll need to recalculate the screen coordinates both after hitting record and stop recording.