search

sugarlabs / musicblocks

Music Blocks -- A musical microworld
https://musicblocks.sugarlabs.org/
GNU Affero General Public License v3.0
558 stars 757 forks source link

Temperament widget number input is broken #3917

Closed pikurasa closed 3 months ago

pikurasa commented 3 months ago

Description

The Temperament widget doesn't seem to allow you to input numbers atm (e.g. changing the division for Equal).

Expected Behavior

It is expected that the user can change the number input at any time.

Video of issue

temperament-cannot-input-numbers.webm

In the video, I am trying to modify the number by clicking on the numbers, but it is not allowing a way to change anything.

How to Reproduce

  1. Open up Temperament widget
  2. Click on any number
  3. There will be no way to modify the number within the widget

Console log Errors:

I don't see anything particular in the console.

Environment:

I'm testing https://musicblocks.sugarlabs.org/ on Version 120.0.6099.224 (Official Build) built on Debian 11.8, running on Debian 11.7 (64-bit)

walterbender commented 3 months ago

I confirmed it still works in v3.5.5. And I tried backporting the changes to temperament.js to that version and it still works. So I suspect it is either some CSS change? Investigating.

walterbender commented 3 months ago

It seems that input is broken on all of the widgets.

walterbender commented 3 months ago

@AbhijeetAnand45 I isolated the problem to commit 5413a5bea62b2c35429446243ac357953c8d2c0a which is your bulk delete code. I suspect that somehow you are introducing an element that is sitting on top of the input? Cannot think of what else it could be.