Regression: 'Set Default Instrument' Block Converts to 'Unknown' Block

dubeanant commented 6 days ago

I encountered an issue with the "Set Default Instrument" block on the [Music Blocks Programming Guide page](URL of the page where you found the issue). Whenever I attempt to use this block, it converts to an "Unknown" block, which affects the overall functionality and user experience.

Expected Behavior

The "Set Default Instrument" block should retain its intended functionality and not change to an "Unknown" block upon selection.

https://github.com/user-attachments/assets/a83809fb-e5f8-407b-b366-6e88e0dc0589

How to Reproduce:

Open the Music Blocks programming environment.
Navigate to the block palette and select the "Set Default Instrument" block.
Observe that the selected block changes to an "Unknown" block.

Console log Errors: no

Environment:

Operating System: [e.g., Windows, macOS, Linux]
Browser: [e.g., Chrome, Firefox, Safari]
Version of Software/Project: [e.g., v1.0.0]

Checklist

✅ I have read and followed the project's code of conduct.
✅ I have searched for similar issues before creating this one.
✅ I have provided all the necessary information to understand and reproduce the issue.
✅ I am willing to contribute to the resolution of this issue.

omsuneri commented 6 days ago

i m willing to work on this issue @dubeanant

dubeanant commented 6 days ago

Go ahead, @omsuneri. A quick look at js/blocks/ToneBlocks.js reveals that the macro definition for setdefaultinstrument is using the wrong block name, which should solve the issue.

pikurasa commented 4 days ago

i m willing to work on this issue @dubeanant

Just let us know if you need any help. Otherwise, feel free to submit a purge request.

omsuneri commented 4 days ago

the issue is solved as on clicking set default instrument now the tone block of set default instrument is poping out instead of that unknown one so if its fine should i move ahead for the PR @pikurasa @dubeanant

https://github.com/user-attachments/assets/1488a124-7d15-40c9-ae3a-404dfe9b7139

walterbender commented 4 days ago

Please go ahead with the PR

omsuneri commented 4 days ago

Okay @walterbender

sugarlabs / musicblocks