search

sugarlabs / physics

a box2d playpen
GNU General Public License v3.0
7 stars 26 forks source link

Add max_participants = 4 in activity.info #16

Closed devAbnull closed 8 years ago

devAbnull commented 8 years ago

Without this property max_participant user cannot invite other users to join a shared activity if condition in jarabe.view.buddymenu.py #L186 is not satisfied wihout this property link --> https://goo.gl/SoqYZW

walterbender commented 8 years ago

Hmm. I am fine with adding max_participants, but maybe it should be something more like 3-4. I don't 100 is going to work. Also, I am surprised collaboration does not work without it. It was suppose default to max_participant == no limit if the field was missing. Did something change in the toolkit?

devAbnull commented 8 years ago

self._max_participants is initialized to 0 in sugar3/bundle/activitybundle.py If the filed is missing then max_participants will remain zero!

walterbender commented 8 years ago

/me needs to investigate. As I recall, we were ignoring max_participants if it was not set in the activity for backward compatibility.

walterbender commented 8 years ago

Here is what I have observed:

If there is no max_participants set in activity.info, then the default of 0 is returned In meshbox, the test for shareable is max_participants is 0 or current_participants < max_participants.

So the problem you are experiencing must have its roots elsewhere.

Still, I am OK to set the limit to 4 for Physics (not 100).

devAbnull commented 8 years ago

Forced push with max_participants = 4 This will fix the problem for now. Later the root cause can be investigated.