search

sugarlabs / physics

a box2d playpen
GNU General Public License v3.0
7 stars 26 forks source link

fixes TypeError %X format and keyError-'saveid' #46

Closed Saumya-Mishra9129 closed 4 years ago

Saumya-Mishra9129 commented 4 years ago

TypeError: %X format: an integer is required, not float Reproduction - Start physics -> click on Toggle random color button to turn it off -> try drawing something @quozl @chimosky please review.

Saumya-Mishra9129 commented 4 years ago

783d080 fixes #33.

chimosky commented 4 years ago

Reviewed, thanks.

Can you explain why your solution in 783d080 works? As following the steps in #33 without your solution, the error doesn't persist.

@quozl, the example selected are supposed to be displayed right as nothing happens when I select an example.

Saumya-Mishra9129 commented 4 years ago

Reviewed, thanks.

Can you explain why your solution in 783d080 works? As following the steps in #33 without your solution, the error doesn't persist.

@quozl, the example selected are supposed to be displayed right as nothing happens when I select an example.

The error can be reproduced by making a circle , adding motor and let click on stop button to stop rotation of circle. You can look at issue #27 .

quozl commented 4 years ago

Thanks for noticing that https://github.com/sugarlabs/physics/issues/27 and https://github.com/sugarlabs/physics/issues/33 have the same traceback.

Tested, does fix #33, does fix the traceback of #27, but not the other symptoms there.

Merged with commit message rewrite to include tracebacks. Please use "Fix" instead of "Fixed", see imperative mood in Making Commits. It makes way more sense when reading commit history during problem analysis, and is shorter.