Fix: Sample fails to load

[sparshg]

Closes #49 Regression introduced in f82ca550f392cc514d7bbb27fc05521464e1c808

[sparshg]

@chimosky can you review this, thanks

[chimosky]

Tested bc27870; on the first try, the example doesn't load until you click another button and then you're asked if you want to load the example.

[sparshg]

Hmm, I tried it several times but didn't happen to me,

on the first try

Does this happen everytime you start the activity and try to load the example?

[chimosky]

Does this happen everytime you start the activity and try to load the example?

Yes it does and it also happens on resume.

[sparshg]

Is this the live build? I will try testing it there.

[sparshg]

Tested on live build, works as expected

https://github.com/sugarlabs/physics/assets/43041139/fe160b19-fda8-4827-b164-99944c836255

I used Fedora 38 gnome earlier to test as well.

@quozl Are you facing this issue too?

[quozl]

I'm not in my usual testing facility at the moment, but will be around the 5th August.

[chimosky]

Tested on live build, works as expected

Activities are usually run from the activity ring and not the terminal.

I'll wait for quozl to test.

[quozl]

Tested on Ubuntu 22.04 using bc27870.

• a Pygame window appears before the activity controls, with the controls overlaid, (also occurs on master branch),
• trying to load the first sample gives a message "Error: Cannot open Physics project from this file." (whereas on master it simply hangs as below),
• trying to load the other samples hangs the Pygame window, nothing seems to happen,
• no log messages.

Please develop and test on a current release of a Linux distribution, such as Debian, Fedora or Ubuntu. I've not seen a recent release of Sugar Live Build, so it is not suitable for developing on activities with complex dependencies.

[sparshg]

Thanks, also I use latest fedora gnome to test and develop.

I will try this on Ubuntu again and see what's the issue.

[sparshg]

I installed the latest Ubuntu 23.04 on my hardware to test. The pygame window appeared on top of activity. This was because Ubuntu repositories have pygame 2.1.2, and this issue was fixed in pygame 2.3.0 (#50)

I uninstalled the old version and installed pygame 2.5.0 via pip and this issue was solved.

Also pushed a commit to fix sample 1 loading issue.

I tested launching the activity both ways, through terminal and through sugar desktop env as @chimosky mentioned. The samples are loading as expected and activity seems to work as it was in fedora.

[quozl]

That's great, thanks.

[chimosky]

Tested 062f29a, this is what I noticed.

Screencast from 2023-08-06 14-18-35.webm

[sparshg]

Tested https://github.com/sugarlabs/physics/commit/062f29aa127a5bdab14086e3b431adc1f235c9a8, this is what I noticed.

On which system are you testing on? I will try installing that on a new VM to replicate since Ubuntu 23.06 and Fedora 38 are working fine.

[chimosky]

On which system are you testing on? I will try installing that on a new VM to replicate since Ubuntu 23.06 and Fedora 38 are working fine.

I'm testing on live build and I sadly can't test on ubuntu or fedora 38 at the moment.

[sparshg]

I'm testing on live build and I sadly can't test on ubuntu or fedora 38 at the moment.

That is weird since I tested it to be working on a fresh live build VM last week. I will try to do this again on the latest commit in a new VM of live build just to be safe. I also started it directly from terminal last time so I will try it without terminal too this time.

[sparshg]

I tested the new commit on latest live build in a new VM, there aren't any issues. I didn't change anything except of installing swig and using install-pybox2d script in this repo to install dependencies. Can you try this in a new VM @chimosky?

https://github.com/sugarlabs/physics/assets/43041139/b0eee817-ed0f-4dc8-bff5-8a5e6c3f7bc6

[chimosky]

Tested again, after making some changes to my env and it works as expected. Thanks!