Closed Rishabh42 closed 7 years ago
Thanks, that's good progress. I was hoping to merge this with a few changes, but instead I'll let you consider the changes and add commits to your master
branch, and when you git push
this pull request will update.
Problems;
[ ] the repository will be much larger than needed because of all the Sugar activity bundles you've added, and these will persist in future clones, and they are effectively binaries and not source code,
[ ] some of your changes are in the wrong place, e.g. what you have added to 11-apt.sh
is nothing to do with APT configuration, and the change to APT_INCLUDES
in rpi23-gen-image.sh
is redundant considering the new template files.
[ ] the new template files have names that are inconsistent with the old files,
Suggested changes;
[ ] do not include Sugar activity bundles *.xo
but instead include a list of URLs of bundles and download them if they are not in local cache directory,
[x] move your display manager and activity install code from 11-apt.sh
to a new file in the same directory,
[x] reduce the change to APT_INCLUDES in rpi23-gen-image.sh
as much as possible,
[x] rename the files to rpi2stretch-sugar
and rpi3stretch-sugar
.
Questions;
--no-install-recommends
occurs also in other files, yet you have only changed 04norecommends
file; why are the other places not changed?Please, in future pull requests, do not use your master
branch. Convention is to use a branch for the pull request. Mentioned in Contributing code as "Your BRANCH-NAME can be anything, other than master." Impact is mostly on you, and anybody helping you with git
.
Thanks @quozl for the review, I'll work on sorting out the issues.
I had generated some of the xo files for the activities I have included, should I upload those xo files (probably to GH in a new repo) and then provide a link to download them during the build?
It was suggested by Jonas Smedegaard to set APT::Install-Recommends to true as it controls the installation of some crucial Debian packages (he suggested that turning it off would be like turning off autopilot for an unskilled pilot :sweat_smile: ). Should the setting for this be changed in other places too?
Major changes since the last merger:
Added configuration for auto login
Fixed broken activities
Added 19 new activities
Added a way to delete Write activity on build
Modified APT_INCLUDES
Made 2 different template files for RPi 2 & 3 to minimize modification in rpi23-gen-image.sh