search

sugarlabs / rpi23-gen-image

Advanced Debian "jessie" and "stretch" bootstrap script for RPi2/3
GNU General Public License v2.0
0 stars 1 forks source link

Unzip Dependency #16

Closed amanharitsh123 closed 5 years ago

amanharitsh123 commented 6 years ago

Unzip will be required to unzip the sugar activity packages

Rishabh42 commented 6 years ago

It comes pre installed on Debian, so never had any problems with that. Thanks for adding it though, is it working fine on Ubuntu/schroot now?

amanharitsh123 commented 6 years ago

Yes the script woked fine after installing unzip , but its better to add unzip as a dependency as the script undergo the whole build process and then fails at the end if unzip is not installed.

P.S : I didnt had unzip preinstaled in schroot debian sctretch on ubuntu.

Rishabh42 commented 6 years ago

That's good,and yes, unzip isn't pre-installed on schroot by default.

Rishabh42 commented 6 years ago

But please make the required changes in the template files namely 'rpi2stretch-sugar' & 'rpi3stretch-sugar' instead of the default rpi23-gen-image.sh

amanharitsh123 commented 6 years ago

How can i specify the script dependency there ? I suppose that the rpi2stretch-sugar template file contains the list of packages to be included in the build image and not script dependencies . Please correct me if i am wrong

Rishabh42 commented 6 years ago

The template files are used to add those specific settings/packages when executed with the rpi23-gen-image.sh, please also go through the previous commits and see if you can understand how the template files were created. You might realize how to make the changes then

quozl commented 6 years ago

Yes, unzip is not included in initial debootstrap of a debian stretch schroot, but is included if Sugar is installed.

It is the outer system that runs rpi23-gen-image that needs unzip, because 11-mod.sh does not enter the chroot to run unzip.

So add to both files templates/rpi{2,3}stretch-sugar;

REQUIRED_PACKAGES="${REQUIRED_PACKAGES} unzip"

But even so, this repository branched off upstream as of 14de7039 back in February 2017, and much has changed upstream, so please first rebase to upstream and resolve any consequent problems before correcting such comparatively trivial problems as packages missing from your schroot.

Of considerable merit upstream and yet to be merged are