sugarlabs / rpi23-gen-image

Advanced Debian "jessie" and "stretch" bootstrap script for RPi2/3
GNU General Public License v2.0
0 stars 1 forks source link

Write vs CEdit #9

Open quozl opened 7 years ago

quozl commented 7 years ago

CEdit has numerous problems; it doesn't open files, it doesn't save files. Far worse than the Write flickering, which at least stops eventually.

Fix the flickering in Write, using either the upstream patch to AbiWord, or wait for Debian to package the fix and use their package.

i5o commented 7 years ago

How about http://git.sugarlabs.org/jamedit -> http://activities.sugarlabs.org/en-US/sugar/addon/4519 or https://sites.google.com/site/sugaractivities/jamediaobjects/jamediaeditor

quozl commented 7 years ago

Heh. How 'bout GNOME Edit? :grin:

i5o commented 7 years ago

As long as it supports opening files from journal :P

On 8/18/17, James Cameron notifications@github.com wrote:

Heh. How 'bout GNOME Edit? :grin:

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/sugarlabs/rpi23-gen-image/issues/9#issuecomment-323480513

Hrishi1999 commented 7 years ago

What should we exactly use ? JAMEdit or CEdit?

quozl commented 7 years ago

You should use Write, now that the problem is solved, and also because it is the best available.

quozl commented 7 years ago

Saw on IRC considerable misunderstanding about where the problem is, and how it is solved.

Write is a wrapper around AbiWord. It places the AbiWord widget inside a Sugar activity.

The flickering symptom is in Write.

The flickering problem is really in AbiWord. It happens in AbiWord too.

The fix to both is a patch to AbiWord.

So you have to patch AbiWord, rebuild it, install it, and then Write works fine. That's what I've done for my Ubuntu-based build on x86_64, and that's what you can do for your Debian-based build on ARM.

If you don't have the skills, you can either learn them, or you can wait until Debian apply the patch; though it isn't clear that they will, because the package is orphaned. My fix was made last week. As can be seen in git no patch has been made for a while.

I've given references before, and it seems they were not used, but if you want to learn more about the problem, read bug #4915 and the linked bugs, especially the upstream bug in AbiSource.

@Rishabh42, refer to the large diagram of source code flows that I gave you around 31st March, here's a small diagram suggesting how to build a derivative package of AbiWord;

rishab42-d

Rishabh42 commented 7 years ago

Thanks @quozl for the information, I'm a bit unsure about how to apply the patch though

quozl commented 7 years ago

What have you tried?

Rishabh42 commented 7 years ago

I've gone through the links with the patch attached in the mail you sent me, but I can't figure out how to apply it to abiword. Will dig in more and get back to you

quozl commented 7 years ago

Okay, you've referred to a private mail from a week ago. For transparency and to keep others informed, the mail said this;

Date: Thu, 17 Aug 2017 16:34:49 +1000 From: James Cameron <quozl@laptop.org> To: Rishabh Thaney <rishabhthaney@gmail.com> Subject: Flickering Write activity is fixed

I've spent a few days fixing the AbiWord bug 13791, and as consequence the Write activity no longer flickers.

See updates on

https://bugs.sugarlabs.org/ticket/4915 https://bugzilla.abisource.com/show_bug.cgi?id=13791 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851052

As AbiWord is written in C++, it isn't practical to patch during your build, but you could install a replacement AbiWord package with the patch applied.

Or you might wait for Debian to fix their package.

To rebuild AbiWord with my patch, see the diagram in this issue https://github.com/sugarlabs/rpi23-gen-image/issues/9. You may need to read documentation for git clone, gbp pq, git am and gbp buildpackage. Beyond that, I've no idea what your problem is, because I don't know what you have tried.

quozl commented 6 years ago

Now that AbiWord is patched in Debian for 851052, and therefore Write is fixed, Write should be used in preference to CEdit.

Rishabh42 commented 6 years ago

Fixed in PR #21