search

sugarlabs / showntell-activity

ShowNTell expands the capabilities of ClassroomPresenter to enable users to create presentations on the XO and to record audio descriptions of the slides.
GNU General Public License v2.0
0 stars 6 forks source link

Choose Image button not working #9

Open chimosky opened 6 years ago

chimosky commented 6 years ago

As shown in the gif above, when the Choose image button is clicked nothing happens and nothing in the log gives any hint why.

quozl commented 6 years ago

You may find a window hidden behind the activity, use alt+tab to switch. If so, it's a common problem during porting. Look at other activities that use the ObjectChooser class.

chimosky commented 6 years ago

I'll check.

chimosky commented 6 years ago

@quozl tried alt+tab nothing changed.

quozl commented 6 years ago

Please try with versions 1, 2, 6, and 11. If the feature works in any of these versions, you might figure out why by comparing them.

Please try with 00daf740f45e7e408f53fef155272525139a550b, which was the last commit by @cristian99garcia.

quozl commented 6 years ago

What was your result from testing versions 1, 2, 6 and 11? I've added these versions to the repository, see https://github.com/sugarlabs/showntell-activity/commits/restore and the release tags.

quozl commented 6 years ago

In https://github.com/sugarlabs/showntell-activity/pull/10 (choose image button not working) you say;

Addresses https://github.com/sugarlabs/showntell-activity/issues/9 (choose image button not working) works with a fix at https://github.com/sugarlabs/showntell-activity/pull/8 (flake8 errors).

It seems you may be talking about your last change to toolbars.py in https://github.com/sugarlabs/showntell-activity/pull/8/commits/ae7e74d4cbd5ec8adcc8b37d397f76052d7afae5;

@@ -430,7 +427,7 @@ def __init__(self, this_activity, deck):
                 ds_mounts[i]['title'],\
                 ds_mounts[i]['id']
             if ds_mounts[i]['uri'].find('datastore') > 0:
-                pass
+                journal = i
             else:
                 pendrive = i

As this code you've changed in toolbars.py is not in the latest version of the activity (v11, toolbars.py), I don't think it is worth investigating the problem further. Examine the changes from tags v2 to v11 and apply these, porting to GTK+ 3 as you go;

Then in all probability the problem will be solved, and new problems may become apparent.