viewer.js for zoomable images

sugarlabs / social

A Platform of discussion for the projects, Activities, and Softwares of SugarLabs Organisation.

https://sugarsocial.herokuapp.com/

2 stars 5 forks source link

viewer.js for zoomable images #5

Closed FreddieN closed 5 years ago

FreddieN commented 5 years ago

Hi There,

I have had a go at making most images zoomable. The default XO icon that appears if the user has not specified an image I have set not to zoom as I do not think it is necessary for placeholder images. Let me know if you want them to zoom as well. I've done a gif to show it off: http://fr3ddie.me/192034.gif

This is for the GCI task. Let me know if any issues :)

avinashbharti97 commented 5 years ago

@FreddieN changes do not reflect in output, although code seems to be okay still image zooming is not working. I am not getting any error in chrome but in firefox. error_gci

avinashbharti97 commented 5 years ago

maybe this can help issue

avinashbharti97 commented 5 years ago

Apologies, It worked :+1: It was a cache issue :D