sugarlabs / sugar-artwork

Sugar icons and themes
Apache License 2.0
11 stars 33 forks source link

added entry color changes #101

Closed sanatankc closed 6 years ago

sanatankc commented 6 years ago

Pull request is not complete at the moment. Because I am not able to test them locally.

TODO

sanatankc commented 6 years ago

Thanks to @quozl @i5o @walterbender, I finally figured out that changes are actually need to be done in 3.20. I have removed white border and additionally also fixed buttons height and margin.

screen shot 2017-12-20 at 5 39 39 pm

Weirdly, entry's color is not fixing. I tried

spinbutton entry {
    color: #000000;
}

Though, setting background-color, works.

spinbutton entry {
    background-color: #000000;
}
sanatankc commented 6 years ago

On entry no css related to Text is working. I thinks is in different node inside entry node. But can't say what.

Alternative

It is bit radical. But if we couldn't able to change text color, why don't we change background of entry. Like this: screen shot 2017-12-20 at 9 41 19 pm Let me know what you guys think about this, @quozl @walterbender @i5o

quozl commented 6 years ago

No objection. Looks cleaner to me. You might also try changing the - and + foreground colour to differentiate slightly from text foreground colour.

Otherwise, consult with the GTK+ project to figure out how to set the text foreground colour.

sanatankc commented 6 years ago

Thanks @quozl, I have updated spin button to differentiate between entry color and buttons.

screen shot 2017-12-21 at 6 48 12 am