search

sugarlabs / sugar-artwork

Sugar icons and themes
Apache License 2.0
11 stars 33 forks source link

Remove double line in menuitem separators #29

Closed manuq closed 10 years ago

manuq commented 10 years ago

We used padding in menuitem separators to add space between the separator line and the items. The original Sugar theme had a space of 1 subcell above and below the line.

Padding worked fine in GTK+ packaged in F18. At that time I first tried margin, but didn't work.

Now with sugar-build in F20 we see a double line. Painting the border yellow we can see what is happening (see picture attached to this PR).

The proper fix should be changing padding to margin. But turns out margin is not working yet. I'll report this to GTK+. In the mean time, I think loosing the space is a good compromise to prevent the ugly double line.

manuq commented 10 years ago

border-yellow

dnarvaez commented 10 years ago

Pushed. It sounds like we can improve this, but it is such a bad bug that I think it's worth the not-yet-perfect fix.