sugarlabs / sugar-artwork

Sugar icons and themes
Apache License 2.0
11 stars 33 forks source link

Fix treeview background, fixes #4855 #62

Closed samdroid-apps closed 9 years ago

samdroid-apps commented 9 years ago

This also therefore fixes #4857

Main ticket: http://bugs.sugarlabs.org/ticket/4855 Journal ticket: http://bugs.sugarlabs.org/ticket/4857

@walterbender could you test if this breaks anything on fedora 19?

samdroid-apps commented 9 years ago

@walterbender just tested and it didn't seem to break

godiard commented 9 years ago

@samdroid-apps. should we keep the old rule for backward compatibility? Was tested on F18?

samdroid-apps commented 9 years ago

The old rule seems to break the newer versions.

It was not tested on F18... But do we still support that?

quozl commented 9 years ago

Let me know when you drop support for Fedora 18 and I'll fork all the repositories. ;-)

tchx84 commented 9 years ago

@samdroid-apps yeah, we still support it... a lot of users still run Sugar on top of fc18.

samdroid-apps commented 9 years ago

OK.

Would somebody be able to test on f18; I do not have access to an installation?

On Thu, 11 Jun 2015 4:51 pm Martin Abente Lahaye notifications@github.com wrote:

@samdroid-apps https://github.com/samdroid-apps yeah, we still support it... a lot of users still run Sugar on top of fc18.

— Reply to this email directly or view it on GitHub https://github.com/sugarlabs/sugar-artwork/pull/62#issuecomment-111308576 .

quozl commented 9 years ago

Sure, please check my test method:

This is what it looks like on Fedora 18:

screenshot of _log activity_

So you will probably have to write a conditional wrapper in the .css.em files, so use GTK_VERSION, discovered by configure.ac, substituted in gtk3/theme/Makefile.am. Let me know if you have any questions on that. GNU autotools for the win.

samdroid-apps commented 9 years ago

Replacing...