Fix treeview background, fixes #4855

[samdroid-apps]

Replaces #62

This also therefore fixes #4857

This also introduces the requirement of using gi.repository.Gtk during build time of sugar artwork.

Main ticket: http://bugs.sugarlabs.org/ticket/4855 Journal ticket: http://bugs.sugarlabs.org/ticket/4857

[godiard]

@samdroid-apps , this test will break with Gtk 4.0, right?

We need check gtk_mayor >= 3 and gtk_minor > 8, then maybe is cleaner define a variable at the top "new_treeview_background" or something similar. (of course, we can't know if in the future rules will change again :/ )

As a style note, could you add a space between the "]" and the css code to make it easier to read? From

+$[if gtk_minor > 8]GtkTreeView row:even
+$[else]GtkTreeView row:nth-child(even)
+$[end if] {
     background-color: @row_even;
 }

to

-GtkTreeView row:nth-child(even) {
+$[if gtk_minor > 8] GtkTreeView row:even
+$[else] GtkTreeView row:nth-child(even)
+$[end if] {
     background-color: @row_even;
 }

[samdroid-apps]

Sounds like a good idea! I will do it asap

On Mon, 15 Jun 2015 3:22 am Gonzalo Odiard notifications@github.com wrote:

@samdroid-apps https://github.com/samdroid-apps , this test will break with Gtk 4.0, right?

We need check gtk_mayor >= 3 and gtk_minor > 8, then maybe is cleaner define a variable at the top "new_treeview_background" or something similar. (of course, we can't know if in the future rules will change again :/ )

As a style note, could you add a space between the "]" and the css code to make it easier to read? From

+$[if gtk_minor > 8]GtkTreeView row:even +$[else]GtkTreeView row:nth-child(even) +$[end if] { background-color: @row_even; }

to

-GtkTreeView row:nth-child(even) { +$[if gtk_minor > 8] GtkTreeView row:even +$[else] GtkTreeView row:nth-child(even) +$[end if] { background-color: @row_even; }

— Reply to this email directly or view it on GitHub https://github.com/sugarlabs/sugar-artwork/pull/63#issuecomment-112008872 .

[samdroid-apps]

Replaced by #64