search

sugarlabs / sugar-artwork

Sugar icons and themes
Apache License 2.0
11 stars 33 forks source link

Don't set background to black when long-pressing buttons. #76

Closed i5o closed 9 years ago

i5o commented 9 years ago

Before Gtk 3.18 the buttons were fully grey when they were clicked (long press). With gtk 3.18 it shows a black square, rounded with a grey border.

This is a regression, so this restore the previous behaviour

Also tested on XO-4 (with old Gtk version) and this patch doesn't broke the normal behaviour

samdroid-apps commented 9 years ago

I will test

quozl commented 9 years ago

reviewed.

godiard commented 9 years ago

Is this change compatible with Gtk < 3.18 ?

samdroid-apps commented 9 years ago

"Also tested on XO-4 (with old Gtk version) and this patch doesn't broke the normal behaviour"

On Sun, 11 Oct 2015 5:02 pm Gonzalo Odiard notifications@github.com wrote:

Is this change compatible with Gtk < 3.18 ?

— Reply to this email directly or view it on GitHub https://github.com/sugarlabs/sugar-artwork/pull/76#issuecomment-147161351 .

quozl commented 9 years ago

Not yet mentioned above is that XO-4 with 13.2.5 has Gtk+ versions 3.6 and 2.24, and that with 14.1.0 has Gtk+ versions 3.10 and 2.24. Not tested this patch myself.

samdroid-apps commented 9 years ago

14 is unreleased isnt it?

quozl commented 9 years ago

Complexity involved that question is difficult to simplify. We have one customer using it at least, as custom build they make from our collection of git repositories and packages. But my builds don't meet my requirements for stability and usability so I've not made a release yet. Several of the problems have been impossible to solve with the available resources. There has been very little interest or contributed work.

samdroid-apps commented 9 years ago

OK, I'll give it a test on 14. Is there a 106 build, or is there only the 104 version?

quozl commented 9 years ago

Only 0.104. Link by mail.

Upgrading to 0.106 is easy.

sudo su
wget \
http://rpmdropbox.laptop.org/f18/sugar-cp-power-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-datetime-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-backup-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-frame-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-modemconfiguration-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-language-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-updater-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-webaccount-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-network-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-cp-background-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-0.106.1-1.fc18.noarch.rpm \
http://rpmdropbox.laptop.org/f18/sugar-toolkit-gtk3-0.106.1-1.fc18.armv7hl.rpm
rpm -U sugar*
service olpc-dm restart