search

sugarlabs / sugar-artwork

Sugar icons and themes
Apache License 2.0
11 stars 33 forks source link

Explicitly style ToolButton insensitive state, fixes #4901 #77

Closed samdroid-apps closed 9 years ago

samdroid-apps commented 9 years ago

The insensitive state of ToolButtons was implicitly styled, however newer Gtk+ versions have broken this behaviour.

Ticket https://bugs.sugarlabs.org/ticket/4901

i5o commented 9 years ago

Testing

i5o commented 9 years ago

XO: http://i.imgur.com/C0yAScV.png Sugar-build f23 mode_none: http://i.imgur.com/YFLr2Zk.png

In XO is less grey, so maybe we should turn a bit less the opacity.

i5o commented 9 years ago

I will test this patch on XO, to see if it doesn't break the normal behaviour

i5o commented 9 years ago

Doesn't break the normal behaviour on XO.

The insensitive color (on read activity) of buttons should be:

949294 (like normal behaviour on white buttons)

But it's

707070 :-/

This could work for now, but for some reason the opacity needs to be a bit more lower/higger?

i5o commented 9 years ago

Tested opacity: 0.5 and the normal color (before the insensitive style were broke) and works.

i5o commented 9 years ago

Tested that opacity on XO, and doesnt broke the normal behaviour ;D

i5o commented 9 years ago

So, In resume, for a nice work we need to change the opacity to 0.5