sugarlabs / sugar-artwork

Sugar icons and themes
Apache License 2.0
11 stars 33 forks source link

Migrate entry styles to "css nodes" #81

Closed samdroid-apps closed 8 years ago

samdroid-apps commented 8 years ago

Upstream, gtk has changed to using "css nodes" [1]. This is a first pass conversion that preserves most of the styles.

[1] https://github.com/GNOME/gtk/commit/bb7d7851ac5cecf960a7ed69af06b2dd0a29484b

Gtk3 version: gtk3-3.19.1-1.fc24.x86_64

Before

https://gyazo.com/36a77ce4eb1f60f05c56e0685add4d4d

After

i5o commented 8 years ago

Reproduced on:

[tamara@tamara-laptop sugar-build]$ lsb_release -a
LSB Version:    :core-4.1-ia32:core-4.1-noarch:cxx-4.1-ia32:cxx-4.1-noarch:desktop-4.1-ia32:desktop-4.1-noarch:languages-4.1-ia32:languages-4.1-noarch:printing-4.1-ia32:printing-4.1-noarch
Distributor ID: Fedora
Description:    Fedora release 24 (Rawhide)
Release:    24
Codename:   Rawhide
[tamara@tamara-laptop sugar-build]$ pkg-config --modversion gtk+-3.0
3.19.1
[tamara@tamara-laptop sugar-build]$ 
i5o commented 8 years ago

The patch works.

Testing on XO-1

i5o commented 8 years ago

Also @samdroid-apps can you change:

.separator {
}

to

separator,
.separator {
}

Without that the separators aren't being showed (due to incorrect name in css) With that they are shown

i5o commented 8 years ago

Doesn't break current support for old versions. will merge after you change that (if you can)

samdroid-apps commented 8 years ago

Ok, just pushed that as another commit, because they are kind of separate. Thanks for finding that though!

i5o commented 8 years ago

Merged