Gtk3 19 regressions - Githubissues

samdroid-apps commented 8 years ago

2 commits to fix some of the broken things in sugar. Please see the commit log for details.

Neither have been tested against older gtk versions. Any tests are appreciated. There should be no visual change after applying the patch.

I have not created a bug to represent the issues that I'm seeing on fedora rawhide, although many appear to be due to Gtk+ issues that also effect gnome. I'll keep a list here for the time being:

[ ] No padding in the toolbars. This also happens in other places, eg. GNOME's text selection touch popover (which sugar should add css for, but that's another discussion)
[x] Toolbar colours broken
[ ] Scales are inivisble
[ ] Progressbars are also invisible
[ ] All palettes (very recently) lost their borders
[ ] Lots of random things got borders. Eg. every spacer in the toolbar. However, that is also in GNOME (eg. menus)
[x] The home view selector has radio buttons tiled as the background

samdroid-apps commented 8 years ago

NOTE: this was tested against gtk3-3.19.5-2.fc24.x86_64 only/

samdroid-apps commented 8 years ago

Gtk3.19/20 is a way bigger cycle that I though. They have migrated from using GtkXYZ and .xyz selectors to mainly css nodes ("xyz" selectors). This is going to give future standardisation, but it means a huge change now.

See https://blogs.gnome.org/mclasen/2015/11/20/a-gtk-update/ and for some cool new features to migrate to: https://blogs.gnome.org/mclasen/2015/12/22/css-boxes-in-gtk/

Anyway, I will have to use a different approach.

sugarlabs / sugar-artwork

Gtk3 19 regressions #84