Closed ezequielpereira closed 7 years ago
Forgot to mention bug 4909, which contains an easy test case.
Added to the description.
May the image be png instead of gif? We have no gif in sugar-artwork now, and gif has had an unfortunate history.
Updated.
Now the background image is in SVG format.
Thanks. This and the related PRs,
Reviewed-by: James Cameron <quozl@laptop.org>
Testing.
Not working for me, for some reason? Maybe I build in wrong way or applied bad the patch?
There is a toolkit patch as well (or maybe a shell patch?)
Applied sugar-artwork and sugar one, that was my result
@i5o On sugar-build the new files aren't added in the build folder, maybe that's the problem.
i'm doing a osbuild clean & pull, and then will apply your patchs & build
Nop, didn't worked..
Check build/out/install/share/themes/sugar-72/gtk-3.0/assets/viewsource-imageBox-bg.svg, it should be there (or not).
@163gal, you did not change gtk3/theme/assets/Makefile.am?
And here is the why: You forgot to add "viewsource-imageBox-bg.svg" to Makefile.am .
From me it's a -1 for design. Sorry I don't feel comfortable seeing this..
Let me say I don't know how sugar-build works...
+1 for design, -1 for build system implementation. easily fixed. i don't know how sugar-build works either, but the same problem would have appeared with "make install", therefore rpmbuild or dpkg-buildpackage.
Do you really feel comfortable with that?.. See it for few seconds and move around..
I fixed the problem in Makefile.am. @i5o How do you want it?
@163gal I think the black is too black? How about with the toolbars color?
Tested with #282828, I think the problem is that the squares are too small :P
@i5o, what screen DPI and resolution?
@quozl
[ignacio@localhost sugar-build]$ xdpyinfo | grep -B2 dots
screen #0:
dimensions: 1440x838 pixels (381x222 millimeters)
resolution: 96x96 dots per inch
[ignacio@localhost sugar-build]$
Thanks. A fairly low DPI. Have you a 200 DPI screen you can check with?
Maybe add another 0 to each number in the background grid? Does that fix the size?
Also, why do you have a grid of circles? Why not rects? https://developer.mozilla.org/en-US/docs/Web/SVG/Element/rect
@samdroid-apps it is a grid of circles because of the convert command.
Ok, drawing lots of svg circles can't be good for performance. Maybe hand crafting the svg is better here?
@samdroid-apps Done.
Tested on 13" 1080p screen (so high dpi) with sugar-100 theme.
Image:
I updated the commit, the sugar-100 tiles are now bigger.
Thanks. Cherry-picked for OLPC builds. Don't see why this isn't merged by Sugar Labs.
Oops. I probably forgot, but last time we discussed about the tile size.
I will test it asap
Testing this and https://github.com/sugarlabs/sugar/pull/641 ATM.
@samdroid-apps can you test in high-dpi setup?
Just tested, looks really good for me. You can even notice some part of white icons
Will re-test and then merge.
Yay.
Okay it does not work on fedora 25, maybe due to Gtk changes, but I'll merge it anyway.
@quozl reviewed, and it worked for me in older versions (screenshots are attached in few messages ago ) of fedora/gtk.