search

sugarlabs / sugar-artwork

Sugar icons and themes
Apache License 2.0
11 stars 33 forks source link

Support <ctrl>Tab and <ctrl><shift>Tab shortcuts on all notebooks #89

Closed samdroid-apps closed 8 years ago

samdroid-apps commented 8 years ago

Many activities, for example Pippy [1], add these shortcuts in Python code. Coding all of these is a waste of time - just adding more copy and paste code, although it can make some good beginner GCI tasks.

Humor aside, this patch adds the basic infrastructure for our Gtk+ "key theme". By using a key theme, we can change the shortcut for every Gtk3 notebook (tab widget) on the computer.

[1] https://github.com/sugarlabs/Pippy/blob/ec11963a443bb64b0042ae67175ecf9450490137/notebook.py#L248

samdroid-apps commented 8 years ago

This was tested on Browse, under the assumption that browse did not implement the ctrl-tab behaviour in python code. That was an incorrect assumption. The patch doesn't work. I'll investigate and update it later.