search

sugarlabs / sugar-artwork

Sugar icons and themes
Apache License 2.0
11 stars 33 forks source link

Fix control panel search result highlight #93

Closed quozl closed 8 years ago

quozl commented 8 years ago

Suppress opacity error on Gtk+ 3.6.

On Fedora 18 with Gtk+ 3.6, since 5a7cc8b7 an error is logged because opacity is not known; it was introduced in Gtk+ 3.8. Condtionally refer to it instead.

Fix control panel search result highlighting.

On Ubuntu 16.04 with Gtk+ 3.18 the control panel search does not highlight; the section icons are insensitive and cannot be clicked, but they have no change in appearance. Add an opacity declaration for insensitive widgets.

Question for reviewers; how would the selector be made more specific?

samdroid-apps commented 8 years ago

In the 320 theme, I use the following selector:

controlpanel image:disabled {                                                   
    opacity: $(disabled_opacity);                                               
}

Maybe you could use widget.get_style_context().add_style_class("xyz") to help make that selector more sensitise?

samdroid-apps commented 8 years ago

Did you intend to make the selector more specific?

quozl commented 8 years ago

When I return to the task, yes.

Don't let me hold you up. You can always cherry-pick 1fd56864 if you like, and make the change you propose to b03bcfb, with an author attribution on the commit, and when I next merge I'll notice the commit and test.