Closed ndefilippis closed 8 years ago
Sorry, but your commit contains git conflict markers, please try again and check your commit carefully before sending pull request.
Perhaps you might ask for help on rebasing in the previous pull request? I'm happy to help there or on IRC.
What are conflict markers?
Conflict markers are inserted by git during a merge, and you are expected to resolve them, edit them out, and complete the commit. When you've left them in a commit it means you didn't finish resolving before commit.
Also, you might like to know that you can do a rebase and then force push onto your original pull request. It takes a few careful steps, but it keeps the history of comments in one place. Some of us like that. :grin:
I just reforked and repulled becaues I couldn't figure out rebase