search

sugarlabs / sugar-toolkit-gtk3

Sugar Learning Environment, Activity Toolkit, GTK 3.
GNU Lesser General Public License v2.1
21 stars 80 forks source link

Added example and documentation for colorbutton #359

Closed Hrishi1999 closed 7 years ago

Hrishi1999 commented 7 years ago

The example is tested and it works, though I have a doubt. If I test this example in PEP8, it will give warning about there is no last line at the end of file but if I use flake8, it gives me warning about and empty last line at end of file. Please review it. Update : I have squashed multiple commits.

i5o commented 7 years ago

Please notify the user (maybe by printing it) when the color is changed http://people.sugarlabs.org/ignacio/pi/iaWE678siU.txt

I will wait for @quozl review, as usual he knows this stuff :)

Hrishi1999 commented 7 years ago

Thanks for the snippet (print color_button...). Also, i would go with print (earlier I was adding an alert), but now I would go with just print. Will submit changes soon.

i5o commented 7 years ago

Thanks @Hrishi1999 looks good to me.

Can you squash them and make a single description? Thanks again