[Fix]: #375 (sugar3.activity.widgets.TitleEntry ignores enter key)

sugarlabs / sugar-toolkit-gtk3

Sugar Learning Environment, Activity Toolkit, GTK 3.

GNU Lesser General Public License v2.1

21 stars 80 forks source link

[Fix]: #375 (sugar3.activity.widgets.TitleEntry ignores enter key) #384

Closed rhl-bthr closed 6 years ago

rhl-bthr commented 6 years ago

Fixed in this PR: #375

[X] enter key should dismiss the dialog on activities that use one (most of them except Chat),
[x] test with or without the save-as feature,
[ ] backport to https://github.com/sugarlabs/sugar-toolkit.

Note: This is an in progress PR

Tested on: Sugar 0.112, Ubuntu 16.04

@quozl Kindly review

rhl-bthr commented 6 years ago

I couldn't find an example activity using save-as feature in title entry. I will do a backport after testing with a save-as feature.

quozl commented 6 years ago

Reviewed cd4670f.

To test with save-as, you must enable save-as and restart Sugar. One activity that has an awareness of the save-as feature is Browse, which calls profile.get_save_as. Other activities usually don't need an awareness; save-as is implemented in the toolkit.

rhl-bthr commented 6 years ago

Update: Tested with the save-as feature on Browse.